Combine eslint configs into one monorepo #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhansford
force-pushed
the
big-old-refactor
branch
from
ee0b4cc
to
20cf521
Compare
This commit combines our base and react ESLint configs into one monorepo. It also updates ESLint to v9. I've opted for a monorepo to help reduce the maintenance needed. I explored just having the configs exported from what library, but this would mean non-react projects would have redundant dependencies. Using peer dependencies would be an option, but this would push the maintenance burden downstream to the consumers of the config and I want to avoid that. The ESLint update is a really big breaking change, and so I've temporarily disabled some plugins that weren't working yet. I'm keeping an eye on the Github Issues for these plugins and will re-enable them once they're migrated.
lhansford
force-pushed
the
big-old-refactor
branch
from
20cf521
to
66605de
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit combines our base and react ESLint configs into one
monorepo. It also updates ESLint to v9.
I've opted for a monorepo to help reduce the maintenance needed. I
explored just having the configs exported from what library, but this
would mean non-react projects would have redundant dependencies. Using
peer dependencies would be an option, but this would push the
maintenance burden downstream to the consumers of the config and I want
to avoid that.
The ESLint update is a really big breaking change, and so I've
temporarily disabled some plugins that weren't working yet. I'm
keeping an eye on the Github Issues for these plugins and will re-enable
them once they're migrated.