This repository has been archived by the owner on Mar 7, 2021. It is now read-only.
Add backwards compatbility down to kernel 4.4 (fixes #199) #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4.5 added * copy_file_range (torvalds/linux@2973293) * clone_file_range (torvalds/linux@04b38d6) * dedupe_file_range (torvalds/linux@54dbc15) 4.7 added iterate_shared (torvalds/linux@6192269), a variant of iterate that takes a non-exclusive lock. It sounds like it'd be safe to provide an implementation of iterate_shared as iterate. 4.9 removed aio_fsync (torvalds/linux@723c038), which was never actually used, so we can set it to None in older kernels and not think about it. 4.13 added wait_for_random_bytes (torvalds/linux@e297a78). For now, conditionalize the entire random module on it. All test cases other than random pass on Ubuntu 16.04's kernel. Update the README to say we expect 4.4 onwards to work, possibly with newer Clang for really new kernels (refs #219).
alex
approved these changes
Aug 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4.5 added
4.7 added iterate_shared (torvalds/linux@6192269),
a variant of iterate that takes a non-exclusive lock. It sounds like
it'd be safe to provide an implementation of iterate_shared as iterate.
4.9 removed aio_fsync (torvalds/linux@723c038),
which was never actually used, so we can set it to None in older kernels
and not think about it.
4.13 added wait_for_random_bytes (torvalds/linux@e297a78).
For now, conditionalize the entire random module on it.
All test cases other than random pass on Ubuntu 16.04's kernel.
Update the README to say we expect 4.4 onwards to work, possibly with
newer Clang for really new kernels (refs #219).