Update mobile documentation #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiloszFilimowski
approved these changes
Sep 23, 2024
guide/react-native/installation.mdx
Outdated
| npx create-expo-app@latest my-video-app | ||
| ``` | ||
| <details> | ||
| <summary>Follow these steps to create new mobile app</summary> |
There was a problem hiding this comment.
nitpick:
Suggested change
| <summary>Follow these steps to create new mobile app</summary> | |
| <summary>Follow these steps to create a new mobile app</summary> |
guide/react-native/installation.mdx
Outdated
|
|
||
| </TabItem> | ||
| </Tabs> | ||
| As next step, you have to generate native files with `expo prepare` command: |
There was a problem hiding this comment.
suggestion:
Suggested change
| As next step, you have to generate native files with `expo prepare` command: | |
| As the next step, you have to generate native files with `expo prepare` command: |
guide/react-native/installation.mdx
Outdated
| ``` | ||
| npm install @fishjam-cloud/react-native-client | ||
| ``` | ||
| Your app will need to have configured permissions to use microphone and camera in order to work. |
There was a problem hiding this comment.
nitpick:
Suggested change
| Your app will need to have configured permissions to use microphone and camera in order to work. | |
| Your app must have permissions configured to use the microphone and camera. |
guide/react-native/installation.mdx
Outdated
|
|
||
| ::: | ||
| No action is required for iOS |
There was a problem hiding this comment.
issue: On iOS you need NSCameraUsageDescription and NSMicrophoneUsageDescription in Info.plist, otherwise the app will crash.
MiloszFilimowski
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add more info about mobile docs
Add plugin for npm/yarn tab generation
Enable
bashsyntax coloringAdd new social card (two lines of text, instead of three