-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation on Screen Sharing for mobile app #14
Merged
Merged
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
92057f7
Add new plugin
mironiasty 0ff44a8
Update installation guide
mironiasty 9843979
Update social card
mironiasty 391d9fe
Update connecting instruction
mironiasty 16314fb
Add bash syntax
mironiasty 328dfdd
Format
mironiasty 09d99b0
spelling
mironiasty 3a13d66
Formatting
mironiasty fe2ef77
Add screen sharing installation
mironiasty 3facd43
Screen share usage
mironiasty f628a5a
Add background service
mironiasty 0a6483d
Fix spelling
mironiasty 7b23aa9
Merge remote-tracking branch 'origin/main' into moar-docs-screenshare
mironiasty 8e40a44
Update forgroud service
mironiasty File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,3 +20,9 @@ js-server-sdk | |
Docusaurus | ||
pre-configured | ||
TabItem | ||
AndroidManifest.xml | ||
iOS | ||
Xcode | ||
UI | ||
dev | ||
Podfile |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
--- | ||
sidebar_position: 6 | ||
--- | ||
|
||
import Tabs from "@theme/Tabs"; | ||
import TabItem from "@theme/TabItem"; | ||
|
||
# Streaming from background | ||
|
||
On Android, it is possible to continue streaming when app is in background. Unfortunately this functionality is not available on iOS (due to Apple limitations) | ||
|
||
Below is configuration required to make it work: | ||
|
||
<Tabs groupId="app-type"> | ||
|
||
<TabItem value="expo" label="Expo"> | ||
|
||
You need to modify `app.json` file and add our plugin: | ||
|
||
```json | ||
{ | ||
"expo": { | ||
... | ||
"plugins": { | ||
... | ||
[ | ||
"@fishjam-cloud/react-native-client", | ||
{ | ||
"android": { | ||
"enableForegroundService": true | ||
} | ||
} | ||
], | ||
... | ||
} | ||
} | ||
} | ||
``` | ||
|
||
</TabItem> | ||
<TabItem value="rn" label="Bare workflow"> | ||
|
||
You need to modify `AndroidManifest.xml` file and add below service: | ||
|
||
```xml | ||
<manifest xmlns:android="http://schemas.android.com/apk/res/android"> | ||
... | ||
<application ...> | ||
... | ||
<service android:name="io.fishjam.reactnative.FishjamForegroundService" android:foregroundServiceType="camera|microphone|mediaProjection"/> | ||
</application> | ||
</manifest> | ||
``` | ||
|
||
</TabItem> | ||
</Tabs> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: Are you sure this is true? I think it's possible to achieve using CallKit (at least audio, this is what google meets does), however our app does not support it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is investigation done by Angelika. We might work on this in future, to make it work somehow.