Add quick setup instruction #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mironiasty
commented
Sep 23, 2024
.vscode/launch.json
Outdated
There was a problem hiding this comment.
This allows to start docs directly from vscode, without need to run yarn start from terminal. Quite useful IMO
mironiasty
requested review from
MiloszFilimowski,
kamil-stasiak and
czerwiukk
MiloszFilimowski
approved these changes
Sep 23, 2024
| @@ -130,5 +130,3 @@ dist | |||
| .pnp.* | |||
|
|
|||
| build | |||
|
|
|||
| .vscode | |||
There was a problem hiding this comment.
issue (non-blocking): I wouldn't add the whole folder into the repo as developers have their project configs.
You can whitelist a file using an exclamation mark.
!.vscode/launch.json
guide/index.md
Outdated
|
|
||
| ### Show other participants | ||
|
|
||
| Fetching other participants of your room, can be done with `us` hook. And to display their video stream, you can use |
There was a problem hiding this comment.
typo:
Suggested change
| Fetching other participants of your room, can be done with `us` hook. And to display their video stream, you can use | |
| Fetching other participants of your room, can be done with `useParticipants` hook. And to display their video stream, you can use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add quick setup instruction and few small configuration changes