FCE-457: Allow user to only initialise audio or video #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czerwiukk
approved these changes
Jan 14, 2025
Comment on lines
39
to
42
| const constraints = { | ||
| video: enableVideo ? videoManager.getConstraints() : false, | ||
| audio: enableAudio ? audioManager.getConstraints() : false, | ||
| }; |
There was a problem hiding this comment.
nitpick:
Suggested change
| const constraints = { | |
| video: enableVideo ? videoManager.getConstraints() : false, | |
| audio: enableAudio ? audioManager.getConstraints() : false, | |
| }; | |
| const constraints = { | |
| video: enableVideo && videoManager.getConstraints(), | |
| audio: enableAudio && audioManager.getConstraints(), | |
| }; |
Comment on lines
51
to
54
| let [stream, deviceErrors] = await getAvailableMedia({ | ||
| video: enableVideo ? prepareConstraints(previousDevices.video?.deviceId, constraints.video) : false, | ||
| audio: enableAudio ? prepareConstraints(previousDevices.audio?.deviceId, constraints.audio) : false, | ||
| }); |
There was a problem hiding this comment.
nitpick:
Suggested change
| let [stream, deviceErrors] = await getAvailableMedia({ | |
| video: enableVideo ? prepareConstraints(previousDevices.video?.deviceId, constraints.video) : false, | |
| audio: enableAudio ? prepareConstraints(previousDevices.audio?.deviceId, constraints.audio) : false, | |
| }); | |
| let [stream, deviceErrors] = await getAvailableMedia({ | |
| video: enableVideo && prepareConstraints(previousDevices.video?.deviceId, constraints.video), | |
| audio: enableAudio && prepareConstraints(previousDevices.audio?.deviceId, constraints.audio), | |
| }); |
Comment on lines
30
to
31
| async (params?: UseInitializeDevicesParams) => { | ||
| const { enableVideo = true, enableAudio = true } = params || {}; |
There was a problem hiding this comment.
nitpick:
Suggested change
| async (params?: UseInitializeDevicesParams) => { | |
| const { enableVideo = true, enableAudio = true } = params || {}; | |
| async (params: UseInitializeDevicesParams = { enableVideo = true, enableAudio = true }) => { |
There was a problem hiding this comment.
Do you mean it like that?
async ({ enableVideo = true, enableAudio = true }: UseInitializeDevicesParams = {}) =>
The above solution won't work 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Types of changes
not work as expected)