Fix: allow custom notification fields via inheritance#8
Open
IsaMorphic wants to merge 5 commits intofitomad:mainfrom
Open
Fix: allow custom notification fields via inheritance#8IsaMorphic wants to merge 5 commits intofitomad:mainfrom
IsaMorphic wants to merge 5 commits intofitomad:mainfrom
Conversation
IsaMorphic
force-pushed
the
feature/fix-custom-notification
branch
from
e56e3c3 to
4a99d9c
Compare
IsaMorphic
force-pushed
the
feature/fix-custom-notification
branch
2 times, most recently
from
2e4954a to
7c8496f
Compare
IsaMorphic
force-pushed
the
feature/fix-custom-notification
branch
from
7c8496f to
cc54f21
Compare
IsaMorphic
force-pushed
the
feature/fix-custom-notification
branch
from
6a3d9e6 to
96e1bbd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
APNS documentation states that custom fields can be added to the notification payload by adding extra fields outside of the
apsobject. This pull request addresses this use case by allowing users to subclass and pass arbitrary instances of theNotificationContainerwrapper to theIApnsClient.SendAsyncmethod. The drawback is that the user must manually wrapNotificationinstances before passing them to the main service.