Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #124

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Conversation

conrad-mal
Copy link
Contributor

:)

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@conrad-mal thanks so much for taking the initiative and contributing to our Ad Reporting package!! I have a few change requests in the below comments before this is ready for approval and to be merged into main.

Let me know if you have any questions when making the changes requested below. Thanks 😄

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@fivetran-joemarkiewicz fivetran-joemarkiewicz changed the base branch from main to release/v1.11.0 December 9, 2024 16:52
@fivetran-joemarkiewicz
Copy link
Contributor

@conrad-mal I wanted to bump my change requests in this PR. Our team is planning to merge the next suite of changes to this repo in the upcoming PR #127. We would like to incorporate these changes as well; however, the above requested changes must be applied before we can do so.

If you're able to make these changes in the next day or so that would be great! If not, our team will make these changes directly to your branch so they may be folded into the next release. Thanks and let me know if you have any questions!

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the changes linked as suggestions in this latest review.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged the suggested changes and now this is ready for merging!

@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit ec80b79 into fivetran:release/v1.11.0 Dec 17, 2024
fivetran-catfritz added a commit that referenced this pull request Dec 18, 2024
* release/v0.11.0

* Update CHANGELOG.md

* Feature/linkedin click uri updates (#120)

* feature/linkedin-click-uri-updates

* docs regen and integration schema change

* changelog update

* integration test merge conflict address

* changelog fix

* another changelog fix

* schema change

* Apply suggestions from code review

* Update README.md (#124)

* Update README.md

:)

* Apply suggestions from code review

---------

Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>

* contributor changelog update

* Update CHANGELOG.md

* regen docs

---------

Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Co-authored-by: conrad-mal <conraddick@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants