Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cdm line item #13

Merged
merged 15 commits into from
Aug 14, 2024
Merged

Feature/cdm line item #13

merged 15 commits into from
Aug 14, 2024

Conversation

fivetran-catfritz
Copy link
Contributor

@fivetran-catfritz fivetran-catfritz commented Jun 26, 2024

PR Overview

This PR will address the following Issue/Feature:

  • Quarterly project

This PR will result in the following new package version:

  • v0.3.0 for new model

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

🚨 Breaking Changes 🚨

  • The following columns were added to model stg_recharge__address:
    • country
    • payment_method_id
    • ❗Note: If you have already added any of these fields as passthrough columns to the recharge__address_passthrough_columns var, you will need to remove or alias these fields from the var to avoid duplicate column errors.

Features

  • Added staging model stg_recharge__checkout. See this doc for the fields added and their definitions.

    • This model is disabled by default but can be enabled by setting variable recharge__checkout_enabled to true in your dbt_project.yml file. See the Enable/disable models and sources section of the README for more information.
    • This model can also be passed additional columns beyond the predefined columns by using the variable recharge__checkout_passthrough_columns. See the Passing Through Additional Columns section of the README for more information on how to set this variable.
  • Added the following columns to model stg_recharge__customer. See this doc for field definitions.

    • billing_first_name
    • billing_last_name
    • billing_company
    • billing_city
    • billing_country

Under the hood

  • Updated stg_recharge__subscription_history to coalesce id and subscription_id as the subscription_id since either version can be present in the source.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

  • See internal ticket for schema sample.

If you had to summarize this PR in an emoji, which would it be?

💃

Copy link
Collaborator

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-catfritz no major code changes needed in this PR! The only changes required before approving are including the necessary documentation and CHANGELOG updates.

macros/get_address_columns.sql Show resolved Hide resolved
models/stg_recharge__checkout.sql Show resolved Hide resolved
models/tmp/stg_recharge__checkout.sql Outdated Show resolved Hide resolved
integration_tests/seeds/checkout_data.csv Outdated Show resolved Hide resolved
models/stg_recharge.yml Show resolved Hide resolved
models/src_recharge.yml Show resolved Hide resolved
models/stg_recharge__address.sql Show resolved Hide resolved
Copy link
Collaborator

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-catfritz Looks great! Just one documentation question to address before approval.

README.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@fivetran-catfritz fivetran-catfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now updated!

models/stg_recharge__checkout.sql Show resolved Hide resolved
models/stg_recharge__address.sql Show resolved Hide resolved
models/stg_recharge.yml Show resolved Hide resolved
integration_tests/seeds/checkout_data.csv Outdated Show resolved Hide resolved
macros/get_address_columns.sql Show resolved Hide resolved
models/src_recharge.yml Show resolved Hide resolved
models/tmp/stg_recharge__checkout.sql Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@fivetran-reneeli fivetran-reneeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@fivetran-catfritz fivetran-catfritz merged commit 58ac6a3 into main Aug 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants