update is_most_recent_record in sub history #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@fivetran-reneeli Code changes look good! Suggestion for the changelog, and also left a comment in Height re the validation. Thanks!
CHANGELOG.md
Outdated
| # dbt_recharge_source v0.3.1 | ||
| [PR #15](https://github.com/fivetran/dbt_recharge_source/pull/15) includes the following updates: | ||
| ## Bugfix | ||
| - Updates the `is_most_recent_record` field in `stg_recharge__subscription_history` to partition on `id`, or `subscription_id` if the former is not available in the source table. |
There was a problem hiding this comment.
I would add an explanation of why this had to be done.
fivetran-catfritz
approved these changes
Aug 20, 2024
fivetran-joemarkiewicz
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Thanks @fivetran-reneeli for this quick fix. These changes look good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature: Issue #14
internal ticket where a customer was seeing a partition by constant expression issue due to a null value as the partition key resulting from having
idin their source subscription_history table instead ofsubscription_id. To fix this we separated out the partition so that the coalesce betweenidandsubscription_idoccurred first.This PR will result in the following new package version:
v0.3.1
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Bugfix
is_most_recent_recordfield instg_recharge__subscription_historyto partition onid, orsubscription_idif the former is not available in the source table.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
Hex notebook linked in ticket!
If you had to summarize this PR in an emoji, which would it be?
💃