feature/remove-deprecated-fields#29
Conversation
fivetran-joemarkiewicz
left a comment
fivetran-joemarkiewicz
left a comment
There was a problem hiding this comment.
LGTM just one small CHANGELOG adjustment note, but nothing work blocking release review.
CHANGELOG.md
Outdated
| # dbt_recurly v0.5.0 | ||
| [PR #29](https://github.com/fivetran/dbt_recurly/pull/29) includes the following breaking changes: | ||
| ## Breaking Changes | ||
| - Removed unused fields from `stg_recurly__subscription_history` in the upstream `dbt_recurly_source` package (see [CHANGELOG](https://github.com/fivetran/dbt_recurly_source/blob/main/CHANGELOG.md#dbt_recurly_source-v030)): |
There was a problem hiding this comment.
Small suggestion to link the release notes instead of the CHANGELOG. This way it directs the customer to a focused version of the CHANGELOG in the form of the release.
packages.yml
Outdated
| # - package: fivetran/recurly_source | ||
| # version: [">=0.3.0", "<0.4.0"] | ||
| - git: https://github.com/fivetran/dbt_recurly_source.git | ||
| revision: feature/remove-deprecated-fields | ||
| warn-unpinned: false No newline at end of file |
There was a problem hiding this comment.
Reminder to swap before release.
fivetran-avinash
left a comment
fivetran-avinash
left a comment
There was a problem hiding this comment.
@fivetran-catfritz
Can you also bump the versions of the dbt_project.yml and integration_tests/dbt_project.yml?
One additional suggestion, and after that you should be good!
Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com>
fivetran-catfritz
left a comment
fivetran-catfritz
left a comment
There was a problem hiding this comment.
@fivetran-avinash Thanks for catching the version! I also commited your suggestion.
fivetran-avinash
left a comment
fivetran-avinash
left a comment
There was a problem hiding this comment.
@fivetran-catfritz LGTM
3 participants
PR Overview
This PR will address the following Issue/Feature:
converted_atandhas_started_with_giftfields from subscription history table #38This PR will result in the following new package version:
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
dbt run (if incremental models are present) && dbt testBefore marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
If you had to summarize this PR in an emoji, which would it be?
💃