bug/spine-empty-lead-update

[fivetran-catfritz]

PR Overview

This PR will address the following Issue/Feature:

• Internal ticket
• (possibly) [Feature] Slim down last_date logic in int_salesforce__date_spine - use current_date #49

This PR will result in the following new package version:

• v1.0.2: patch update since updating logic but no schema changes

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Bug fixes

• Updated model int_salesforce__date_spine to accommodate when model salesforce__lead exists but has no records. In this case, the model now defaults to a range of one-month from the current date.

Under the hood

• Updated structure of model int_salesforce__date_spine for improved performance and maintainability.
• Updated maintainer pull request template.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

• dbt run –full-refresh && dbt test
• dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

• The appropriate issue has been linked, tagged, and properly assigned
• All necessary documentation and version upgrades have been applied
• docs were regenerated (unless this PR does not include any code or yml updates)
• BuildKite integration tests are passing
• Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

• For reference, changes are very similar to those I made in v0.13.0 stripe.

• Created consistency and integrity tests for the direct downstream model salesforce__daily_activity, which all pass when run on our internal data.

• I was able to reproduce the issue by supplying an empty lead seed table. Running on the current version produces this error:

• The updates to this package resolve the error and produce the expected spine range:

If you had to summarize this PR in an emoji, which would it be?

🐰

[fivetran-jamie]

ooh la la what's this

[fivetran-jamie]

LGTM!

[fivetran-joemarkiewicz]

@fivetran-catfritz this looks great from my end! Just one suggestion to make a small change in the CHANGELOG. Let me know if I misinterpreted your originally wording.