Merge pull request #40 from jsagasta/journal-id-test-fix

Added journal_id to model test
fivetran · Nov 8, 2023 · 55f4548 · 55f4548
2 parents 37c8d4b + d9bca5a
commit 55f4548
Show file tree

Hide file tree

Showing 9 changed files with 32 additions and 18 deletions.
diff --git a/.gitignore b/.gitignore
@@ -3,4 +3,6 @@ target/
 dbt_modules/
 logs/
 .DS_Store
-dbt_packages/
+dbt_packages/
+env/
+package-lock.yml
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,14 @@
+# dbt_xero v0.6.1
+
+[PR #40](https://github.com/fivetran/dbt_xero/pull/40) includes the following updates:
+
+## Test Updates
+- The unique combination of columns test within the `xero__general_ledger` model has been updated to include `journal_id` in addition to `journal_line_id` and `source_relation`. 
+  - This update is required as deleted journals may still appropriately be rendered in the general ledger; however, they will have no associated journal lines. As such, there may be unique `journal_id`s with a null `journal_line_id`. This test update will account for this scenario.
+
+## Contributors
+- [@jsagasta](https://github.com/jsagasta) ([PR #40](https://github.com/fivetran/dbt_xero/pull/40))
+
 # dbt_xero v0.6.0
 ## 🎉 Feature Update 🎉
 - Databricks compatibility! ([#38](https://github.com/fivetran/dbt_xero/pull/38))

diff --git a/dbt_project.yml b/dbt_project.yml
@@ -1,5 +1,5 @@
 name: 'xero'
-version: '0.6.0'
+version: '0.6.1'
 config-version: 2
 require-dbt-version: [">=1.3.0", "<2.0.0"]
 vars:

diff --git a/docs/catalog.json b/docs/catalog.json
diff --git a/docs/index.html b/docs/index.html
diff --git a/docs/manifest.json b/docs/manifest.json
diff --git a/docs/run_results.json b/docs/run_results.json
diff --git a/integration_tests/dbt_project.yml b/integration_tests/dbt_project.yml
@@ -1,5 +1,5 @@
 name: 'xero_integration_tests'
-version: '0.6.0'
+version: '0.6.1'
 profile: 'integration_tests'
 config-version: 2
 vars:

diff --git a/models/xero.yml b/models/xero.yml
@@ -118,6 +118,7 @@ models:
           combination_of_columns:
             - journal_line_id
             - source_relation
+            - journal_id
     columns:
       - name: journal_line_id
         description: Xero identifier for the journal line.