Skip to content

Commit

Permalink
Add even more reliability to processes test for github CI
Browse files Browse the repository at this point in the history
  • Loading branch information
jjlauer committed Nov 4, 2024
1 parent c14af6e commit 6d9d80d
Showing 1 changed file with 6 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@ public void destroy() throws Exception {

PROCESS_HELPER.destroy(startedProcess.getProcess(), 5000L);

// github actions are slow, make this a bit more reliable
WaitFor.of(() -> !startedProcess.getProcess().isAlive()).awaitMillis(3000L, 50L);

assertThat(startedProcess.getProcess().isAlive(), is(false));
}

Expand All @@ -63,6 +66,9 @@ public void destroyWithDescendants() throws Exception {

PROCESS_HELPER.destroyWithDescendants(startedProcess.getProcess(), 5000L);

// github actions are slow, make this a bit more reliable
WaitFor.of(() -> !startedProcess.getProcess().isAlive()).awaitMillis(3000L, 50L);

assertThat(startedProcess.getProcess().isAlive(), is(false));
}

Expand Down

0 comments on commit 6d9d80d

Please sign in to comment.