Add bytes feature flag
#10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature causes `Slice` to be backed by `bytes::Bytes` rather than `Arc<[u8]>`.
This was referenced Nov 14, 2024
marvin-j97
reviewed
Nov 14, 2024
marvin-j97
reviewed
Nov 14, 2024
marvin-j97
approved these changes
Nov 14, 2024
|
nvm found it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature causes
Sliceto be backed bybytes::Bytesrather thanArc<[u8]>.I copied most of the Slice implementation to keep the change simple and testable. I also added tests to ensure compatibility with all the different ways Slices are created and compared. And switched to generics for PartialOrd/PartialEq to make testing easier and the API more complete.
I've run tests on all three projects locally (with/without the feature flag) and the only other changes required are passing through the bytes feature flag, and some lint related errors in lsm-tree. Will submit PRs to both of those projects shortly.
Required for fjall-rs/fjall#94