Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrc104 Handle S3 403 #5

Merged
merged 9 commits into from
Nov 14, 2024
Merged

wrc104 Handle S3 403 #5

merged 9 commits into from
Nov 14, 2024

Conversation

mixmixmix
Copy link
Member

Adds handling of Access Denied errors from s3 backend and passes them back in a response.

Needed by https://github.com/fjelltopp/who-romania-ckan/issues/104

Testing

Tested with who-romania-ckan deployment, it is build as image v0.5.3c

Checklist

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request).
You may not need to check all boxes.

  • The Jira ticket for this issue has been updated to "Ready to Review" or equivalent.
  • I have developed these changes in discussion with the appropriate project manager.
  • My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • I have performed a self-review of my own code.
  • I have assigned at least one reviewer.
  • I have assigned at least one label to this PR: "patch", "minor", "major".

ChasNelson1990

This comment was marked as outdated.

giftless/error_handling.py Outdated Show resolved Hide resolved
@ChasNelson1990
Copy link
Member

@mixmixmix - are we dropping py3.7 support? What have they done upstream with that?

@mixmixmix
Copy link
Member Author

They moved to 3.12.... The docker image in this repo uses 3.7, but our image in fjelltopp-base-images uses 3.8.

@mixmixmix
Copy link
Member Author

they changed the way how project is built among other things, but there are not changes in documentation - so it is unfinished & out of data in the upstream repo.

@ChasNelson1990
Copy link
Member

They moved to 3.12.... The docker image in this repo uses 3.7, but our image in fjelltopp-base-images uses 3.8.

Let's update the image in this repo to 3.8 and remove the 3.7 tests then? I think that should really be part of this PR so it doesn't just hang forever

@mixmixmix
Copy link
Member Author

Why part of this PR? It was broken before and not sure there is any point in trying to tidy it up now.

@mixmixmix
Copy link
Member Author

done!

@mixmixmix mixmixmix merged commit f228217 into master Nov 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants