Observer: Add support for BLE active scanning #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkleon
force-pushed
the
feature-active-scan
branch
from
ac1d774
to
4584f2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for active scanning as fallback.
While passive scanning is preferred, it's not always working reliably for me. I tested on two different systems, of which one works fine, and the other doesn't:
Works as expected.
Only receives first advertisement (but not subsequent updates for manufacturer data changes):
There are some bug reports in various places upstream (in bleak, bluez and kernel-bluetooth) about only the first advertisement being received correctly when only the manufacturer data changes between advertisements. As far as I can tell these should all be resolved in the above versions though. Maybe some hardware quirk?