Upgrade sql-parser-cst from 0.5.1 to 0.10.0#681
Open
nene wants to merge 4 commits intofkling:masterfrom
Open
Conversation
This version brings BigQuery support, so also add the new language to the dropdown in settings. Notably the syntax tree produced by sql-parser-cst has also had some major changes between 0.5 and 0.8 versions. Normally I would avoid throwing PR-s to AstExplorer for every little upgrade, but this one completely changes how table and column names are represented, making the syntax tree in 0.5.x largely incompatible with the one in 0.8.x.
This fixes a major performance problem.
nene
changed the title
nene
changed the title
nene
changed the title
|
It's on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This version brings BigQuery support, so I also added the new language to the dropdown in settings. Plus the syntax tree produced by sql-parser-cst has had some major changes between 0.5 and 0.8 versions.
Normally I would avoid throwing PR-s to AstExplorer for every little upgrade, but this one completely changes how table and column names are represented, making the syntax tree in 0.5 largely incompatible with the one in 0.8.