Add optional dependencies for com.intellij.modules.java and org.intel…

…lij.scala (#115)
fkorotkov · Feb 24, 2021 · 41e12f9 · 41e12f9
1 parent 2cbdc72
commit 41e12f9
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 8 deletions.
diff --git a/build.gradle b/build.gradle
@@ -17,8 +17,8 @@ subprojects {
 
     apply plugin: 'org.jetbrains.intellij'
     intellij {
-        version ideaVersion
-        plugins = ['copyright', 'java']
+        version project.property("ideaVersion")
+        plugins = ['copyright', 'java', 'org.intellij.scala:2020.3.19']
         downloadSources Boolean.valueOf(sources)
         sameSinceUntilBuild Boolean.valueOf(isEAP)
     }

diff --git a/gradle.properties b/gradle.properties
@@ -1,4 +1,4 @@
-ideaVersion = IC-2020.3.1
+ideaVersion = 2020.3.1
 sources = true
 isEAP = false
 

diff --git a/thrift/src/main/java/com/intellij/plugins/thrift/structure/ThriftStructureViewModel.java b/thrift/src/main/java/com/intellij/plugins/thrift/structure/ThriftStructureViewModel.java
@@ -19,7 +19,6 @@
 import com.intellij.ide.structureView.StructureViewModel;
 import com.intellij.ide.structureView.StructureViewModelBase;
 import com.intellij.ide.structureView.StructureViewTreeElement;
-import com.intellij.ide.structureView.impl.java.VisibilitySorter;
 import com.intellij.ide.util.treeView.smartTree.*;
 import com.intellij.plugins.thrift.lang.psi.ThriftDeclaration;
 import com.intellij.plugins.thrift.lang.psi.ThriftSubDeclaration;
@@ -36,7 +35,7 @@
 public class ThriftStructureViewModel extends StructureViewModelBase implements StructureViewModel.ElementInfoProvider {
   public ThriftStructureViewModel(@NotNull PsiFile psiFile) {
     super(psiFile, new ThriftStructureViewElement(psiFile));
-    withSorters(Sorter.ALPHA_SORTER, VisibilitySorter.INSTANCE);
+    withSorters(Sorter.ALPHA_SORTER);
     withSuitableClasses(ThriftDeclaration.class);
   }
 

diff --git a/thrift/src/main/resources/META-INF/plugin.xml b/thrift/src/main/resources/META-INF/plugin.xml
@@ -120,6 +120,8 @@
   <depends>com.intellij.modules.vcs</depends>
   <depends>com.intellij.modules.xml</depends>
   <depends>com.intellij.modules.xdebugger</depends>
+  <depends optional="true" config-file="withJava.xml">com.intellij.modules.java</depends>
+  <depends optional="true" config-file="withScala.xml">org.intellij.scala</depends>
 
   <application-components>
     <!-- Add your application components here -->
@@ -187,9 +189,7 @@
 
     <frameworkSupport implementation="com.intellij.plugins.thrift.config.facet.ThriftFacetSupportProvider"/>
     <facetType implementation="com.intellij.plugins.thrift.config.facet.ThriftFacetType"/>
-    <compileServer.plugin classpath="thrift-jps.jar;commons-io-2.4.jar"/>
-    <codeInsight.lineMarkerProvider language="Scala" implementationClass="com.intellij.plugins.thrift.editor.GoToThriftDefinitionMarkerProvider"/>
-    <codeInsight.lineMarkerProvider language="JAVA" implementationClass="com.intellij.plugins.thrift.editor.GoToThriftDefinitionMarkerProvider"/>
+    <compileServer.plugin classpath="thrift-jps.jar" />
   </extensions>
 
   <actions>

diff --git a/thrift/src/main/resources/META-INF/withJava.xml b/thrift/src/main/resources/META-INF/withJava.xml
@@ -0,0 +1,6 @@
+<idea-plugin>
+    <extensions defaultExtensionNs="com.intellij">
+        <codeInsight.lineMarkerProvider language="JAVA"
+                                        implementationClass="com.intellij.plugins.thrift.editor.GoToThriftDefinitionMarkerProvider"/>
+    </extensions>
+</idea-plugin>
diff --git a/thrift/src/main/resources/META-INF/withScala.xml b/thrift/src/main/resources/META-INF/withScala.xml
@@ -0,0 +1,6 @@
+<idea-plugin>
+    <extensions defaultExtensionNs="com.intellij">
+        <codeInsight.lineMarkerProvider language="Scala"
+                                        implementationClass="com.intellij.plugins.thrift.editor.GoToThriftDefinitionMarkerProvider"/>
+    </extensions>
+</idea-plugin>