[RWKV7] Remove in-place operations and add gradient checkpointing for v_first
#145
+7
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v_first
, see https://github.com/BlinkDL/RWKV-LM/blob/main/RWKV-v5/src/model.py#L885.v_first
, see https://github.com/BlinkDL/RWKV-LM/blob/main/RWKV-v5/src/model.py#L870.Rationale 1: In-place operations harm gradient computation. A possible error looks like:
Rationale 2: This requires an additional parameter returned for
RWKV7Attention
. However, given the nature of the value embeddings, one expectsRWKV7Attention
at the 0th layer, even if the model is hybrid architecture. Instead of forcing to unify the interface and return values which may cause undefined behavior, an additional value to unpack would sure raise the awareness of hybrid architecture builders.