2.3.x refactoring

flancer32 · Dec 17, 2018 · 2258819 · 2258819
1 parent 4c4ca68
commit 2258819
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/App/Cli/Base.php b/App/Cli/Base.php
@@ -18,8 +18,10 @@ public function __construct($name, $desc)
 
     /**
      * Check area code in commands that require code to be set.
+     * This method should be used in 'execute()' methods (not in'configure()')
+     * to prevent " Area code is already set" error on "setup:upgrade".
      */
-    private function checkAreaCode()
+    protected function checkAreaCode()
     {
         /**
          * I don't use constructor arguments to get dependencies
@@ -41,10 +43,4 @@ private function checkAreaCode()
             $manObj->configure($config);
         }
     }
-
-    protected function configure()
-    {
-        parent::configure();
-        $this->checkAreaCode();
-    }
 }