Skip to content

[2.x] chore: make PostUser more extensible #4252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from
Open

[2.x] chore: make PostUser more extensible #4252

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 46 additions & 21 deletions framework/core/js/src/forum/components/PostUser.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ import Avatar from '../../common/components/Avatar';
import type Model from '../../common/Model';
import type Post from '../../common/models/Post';
import type User from '../../common/models/User';
import ItemList from '../../common/utils/ItemList';
import type Mithril from 'mithril';

export interface IPostUserAttrs extends ComponentAttrs {
/** Can be a post or similar model like private message */
Expand All @@ -22,27 +24,50 @@ export default class PostUser<CustomAttrs extends IPostUserAttrs = IPostUserAttr
const post = this.attrs.post;
const user = post.user();

if (!user) {
return (
<div className="PostUser">
<h3 className="PostUser-name">
<Avatar user={user} className="Post-avatar" /> {username(user)}
</h3>
</div>
);
}

return (
<div className="PostUser">
<h3 className="PostUser-name">
<Link href={app.route.user(user)}>
<Avatar user={user} className="Post-avatar" />
{userOnline(user)}
{username(user)}
</Link>
</h3>
<ul className="PostUser-badges badges badges--packed">{listItems(user.badges().toArray())}</ul>
</div>
const items = user ? this.userViewItems(user, post) : this.noUserViewItems(user, post);

return <div className="PostUser">{items.toArray()}</div>;
}

noUserViewItems(user: false | User | null, post: Post | (Model & { user: () => false | User | null })): ItemList<Mithril.Children> {
const items = new ItemList<Mithril.Children>();

items.add(
'postUser-name',
<h3 className="PostUser-name">
<Avatar user={user} className="Post-avatar" /> {username(user)}
</h3>,
100
);

return items;
}

userViewItems(user: User, post: Post | (Model & { user: () => false | User | null })): ItemList<Mithril.Children> {
const items = new ItemList<Mithril.Children>();

items.add(
'postUser-name',
<h3 className="PostUser-name">
<Link href={app.route.user(user)}>{this.linkChildren(user).toArray()}</Link>
</h3>,
100
);

items.add('postUser-badges', <ul className="PostUser-badges badges badges--packed">{listItems(user.badges().toArray())}</ul>, 90);

return items;
}

linkChildren(user: User): ItemList<Mithril.Children> {
const items = new ItemList<Mithril.Children>();

items.add('avatar', <Avatar user={user} className="Post-avatar" />, 100);

items.add('userOnline', userOnline(user), 90);

items.add('username', username(user), 80);

return items;
}
}
Loading