fix icon in website #578
Merged
fix icon in website #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## deneb-website-blobs #578 +/- ##
====================================================
Coverage 36.22% 36.22%
====================================================
Files 24 24
Lines 5267 5267
====================================================
Hits 1908 1908
Misses 3112 3112
Partials 247 247
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
avalonche
approved these changes
Jan 31, 2024
|
nice, thanks! |
avalonche
added a commit
that referenced
this pull request
Feb 1, 2024
* Add blobs column to website * add default * add marshalling for blob fields * marshalling block validation request * slim column name * fix icon in website (#578) replace website etherscan url with svg --------- Co-authored-by: sukoneck <19413126+sukoneck@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
replace the etherscan icon remote url with an svg.
⛱ Motivation and Context
on the website (eg. boost-relay.flashbots.net) the etherscan icon no longer loads from remote url. chrome throws:
Failed to load resource: net::ERR_BLOCKED_BY_RESPONSE.NotSameOrigin✅ I have run these commands
CONTRIBUTING.md