Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter save builder submissions to all bids #580

Closed
wants to merge 1 commit into from

Conversation

avalonche
Copy link
Collaborator

@avalonche avalonche commented Feb 8, 2024

📝 Summary

Moving the go routine to save builder submissions for all bids. We move the go routine before we return early when a bid is below the floor.

Switching the flag to save all payloads will save the payload for all bids.

⛱ Motivation and Context

Saving all builder bids to analyse builder performance and time intervals between bids.

📚 References


✅ I have run these commands

  • make lint
  • make test-race
  • go mod tidy
  • I have seen and agree to CONTRIBUTING.md

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (108d5e3) 30.44% compared to head (222c297) 30.45%.

Files Patch % Lines
services/api/service.go 76.92% 2 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #580      +/-   ##
==========================================
+ Coverage   30.44%   30.45%   +0.01%     
==========================================
  Files          41       41              
  Lines        6268     6269       +1     
==========================================
+ Hits         1908     1909       +1     
  Misses       4113     4113              
  Partials      247      247              
Flag Coverage Δ
unittests 30.45% <76.92%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@metachris metachris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants