generated from flashbots/go-template
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add basic latency metrics #616
Merged
Merged
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| # syntax=docker/dockerfile:1 | ||
| FROM golang:1.20 as builder | ||
| FROM golang:1.21 as builder | ||
| ARG VERSION | ||
| WORKDIR /build | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,100 @@ | ||
| // Package metrics provides prometheus metrics primitives to the rest of the app | ||
| package metrics | ||
|
|
||
| import ( | ||
| "context" | ||
| "math" | ||
|
|
||
| "go.opentelemetry.io/otel/exporters/prometheus" | ||
| otelapi "go.opentelemetry.io/otel/metric" | ||
| "go.opentelemetry.io/otel/sdk/metric" | ||
| "go.opentelemetry.io/otel/sdk/resource" | ||
| semconv "go.opentelemetry.io/otel/semconv/v1.24.0" | ||
| ) | ||
|
|
||
| const ( | ||
| metricsNamespace = "mev-boost-relay" | ||
| ) | ||
|
|
||
| var ( | ||
| meter otelapi.Meter | ||
|
|
||
| GetPayloadLatencyHistogram otelapi.Float64Histogram | ||
| PublishBlockLatencyHistogram otelapi.Float64Histogram | ||
|
|
||
| latencyBoundaries = otelapi.WithExplicitBucketBoundaries(func() []float64 { | ||
| base := math.Exp(math.Log(12.0) / 15.0) | ||
| res := make([]float64, 0, 31) | ||
| for i := -15; i < 16; i++ { | ||
| res = append(res, math.Pow(base, float64(i))) | ||
| } | ||
| return res | ||
| }()...) | ||
| ) | ||
|
|
||
| func Setup(ctx context.Context) error { | ||
| for _, setup := range []func(context.Context) error{ | ||
| setupMeter, // must come first | ||
| setupGetPayloadLatency, | ||
| setupPublishBlockLatency, | ||
| } { | ||
| if err := setup(ctx); err != nil { | ||
| return err | ||
| } | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| func setupMeter(ctx context.Context) error { | ||
| res, err := resource.New(ctx, | ||
| resource.WithAttributes(semconv.ServiceName(metricsNamespace)), | ||
| ) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| exporter, err := prometheus.New( | ||
| prometheus.WithNamespace(metricsNamespace), | ||
| ) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| provider := metric.NewMeterProvider( | ||
| metric.WithReader(exporter), | ||
| metric.WithResource(res), | ||
| ) | ||
|
|
||
| meter = provider.Meter(metricsNamespace) | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| func setupGetPayloadLatency(ctx context.Context) error { | ||
| latency, err := meter.Float64Histogram( | ||
| "get_payload_latency", | ||
| otelapi.WithDescription("statistics on the duration of getPayload requests execution"), | ||
| otelapi.WithUnit("ms"), | ||
| latencyBoundaries, | ||
| ) | ||
| GetPayloadLatencyHistogram = latency | ||
| if err != nil { | ||
| return err | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| func setupPublishBlockLatency(ctx context.Context) error { | ||
| latency, err := meter.Float64Histogram( | ||
| "publish_block_latency", | ||
| otelapi.WithDescription("statistics on the duration of publishBlock requests sent to beacon node"), | ||
| otelapi.WithUnit("ms"), | ||
| latencyBoundaries, | ||
| ) | ||
| PublishBlockLatencyHistogram = latency | ||
| if err != nil { | ||
| return err | ||
| } | ||
| return nil | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not use
msNeededForPublishing?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fair. updated accordingly.