generated from flashbots/flashbots-repository-template
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add getHeader SSZ support #734
Open
jtraglia
wants to merge
49
commits into
develop
Choose a base branch
from
ssz-get-header
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+527
β70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think they are fine, but two things that caught my attention:
First thought that addresses both of these and simplifies things a bit is if we define a doRequest function inside doRequest := func(accept string) (*http.Response, error) {
req, err := http.NewRequestWithContext(context.Background(), http.MethodGet, url, nil)
if err != nil {
return nil, err
}
// <insert request prep>
req.Header.Set("Accept", accept)
return m.httpClientGetHeader.Do(req)
} Then we can do something like: // ssz attempt
resp, err := doRequest("application/octet-stream")
if err != nil {
β¦
return
}
// json if relay does not support ssz
if resp.StatusCode == http.StatusNotAcceptable {
resp.Body.Close()
logRelay.Debug("SSZ not accepted, trying JSON")
resp, err = doRequest("application/json")
if err != nil {
β¦
return
}
}
defer resp.Body.Close()
// continue rest of execution
... edit: |
This reverts commit b1cda56.
nflaig
reviewed
Feb 5, 2025
nflaig
reviewed
Feb 6, 2025
metachris
reviewed
Feb 13, 2025
metachris
reviewed
Feb 13, 2025
metachris
reviewed
Feb 13, 2025
metachris
reviewed
Feb 13, 2025
metachris
reviewed
Feb 13, 2025
Co-authored-by: Chris Hager <chris@linuxuser.at>
metachris
reviewed
Feb 14, 2025
metachris
reviewed
Feb 14, 2025
metachris
reviewed
Feb 14, 2025
metachris
reviewed
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Summary
This PR adds SSZ support for
getHeader
endpoint. Please see:β I have run these commands
make lint
make test-race
go mod tidy