Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Exclude helm chart tags from appVersion calculation #699

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

mkilchhofer
Copy link
Contributor

It seems that the versioning gets confused by the helm releases also produces git tags.

Before this change:
image

After:
image

How to use

-

Testing done

See screenshots above

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

Copy link
Member

@pothos pothos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this

@pothos pothos merged commit a289105 into flatcar:main Dec 14, 2023
3 checks passed
@mkilchhofer mkilchhofer deleted the bugfix/version_tag branch December 15, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants