Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys-kernel/bootengine: Bump commit for root unlocking service #1787

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

simoncampion
Copy link
Contributor

sys-kernel/bootengine: Bump commit for root unlocking service

Bumps bootengine to version in this PR in flatcar/bootengine. Once merged, I'll change the CROS_WORKON_PROJECT and CROS_WORKON_COMMIT in this PR to point to the flatcar-master.

How to use

See this PR.

Testing done

See this PR.

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

@simoncampion
Copy link
Contributor Author

Once review is finished in the bootengine PR (but before merging), we should run CI against the tests in this kola PR, if possible, and check whether the amd64 and arm64 tests for TPM and Tang pass.

@pothos
Copy link
Member

pothos commented Mar 27, 2024

I've already merged the mantle PR and since you checked that it passed I would not kick of another long-running build here - we also have nightly builds to check for issues.

Copy link

github-actions bot commented Mar 27, 2024

Build action triggered: https://github.com/flatcar/scripts/actions/runs/8464637318

@pothos pothos merged commit a5364e0 into flatcar:main Mar 27, 2024
1 check failed
pothos added a commit that referenced this pull request Mar 27, 2024
sys-kernel/bootengine: Bump commit for root unlocking service
@pothos
Copy link
Member

pothos commented Mar 27, 2024

The last piece now would be to add a new Butane Flatcar config level that allows to use clevis.

@pothos
Copy link
Member

pothos commented Mar 27, 2024

Not sure what merge commit ID I was using but it doesn't exist now 😓

@pothos
Copy link
Member

pothos commented Mar 27, 2024

Ah, it was the mantle merge commit ID

@simoncampion
Copy link
Contributor Author

The last piece now would be to add a new Butane Flatcar config level that allows to use clevis.

Happy to open a PR in coreos/butane for that. Should I add it to Flatcar v1.2.0-experimental, in the code and documentation?

@pothos
Copy link
Member

pothos commented Mar 28, 2024

Yes, sounds right, and then we could stabilize it?

@simoncampion
Copy link
Contributor Author

Sounds good. Since adding Clevis support and stabilizing should probably be done in two separate PRs, I opened a first PR to add it to Flatcar v1.2.0-experimental, without stabilizing. @pothos If the changes look good to you, I'll change the PR from draft to ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants