Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give an example how to install an icon #120

Closed
wants to merge 1 commit into from
Closed

Conversation

razzeee
Copy link
Member

@razzeee razzeee commented Nov 19, 2023

No description provided.

@hfiguiere
Copy link
Contributor

what if this is not buildsystem: simple ?

@hfiguiere
Copy link
Contributor

also this seem to tell people to put them in a separate module.

@razzeee
Copy link
Member Author

razzeee commented Nov 19, 2023

what if this is not buildsystem: simple ?

what else could a script step be?

also this seem to tell people to put them in a separate module.

That's just due to limiting it to one specific example - we could have some [...] around that hint at that, but it seemed more harmful, as newcomers might not realize that?

@TingPing
Copy link

I do think this is odd to document. So many upstreams put installing files in their manifest and not their upstream build system. This isn't behavior to encourage.

@razzeee
Copy link
Member Author

razzeee commented Nov 19, 2023

@TingPing you are correct, but I would like to encourage usage of scalable icons. As scaling stuff down is bad.

@hfiguiere
Copy link
Contributor

That brings nothing to the table. And then in review "I copied this from the documentation"

@razzeee razzeee closed this Nov 19, 2023
@hfiguiere hfiguiere deleted the some-more-icon-infos branch June 3, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants