Skip to content

Commit

Permalink
feed: Get database connection via context manager
Browse files Browse the repository at this point in the history
  • Loading branch information
barthalion committed Sep 5, 2024
1 parent 82653bf commit 202a296
Showing 1 changed file with 9 additions and 10 deletions.
19 changes: 9 additions & 10 deletions backend/app/routes/feed.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from feedgen.feed import FeedGenerator

from .. import db, models
from ..database import get_db_session
from ..database import get_db

if TYPE_CHECKING:
from datetime import datetime
Expand Down Expand Up @@ -46,8 +46,6 @@ def get_new_apps_feed():


def generate_feed(column_name: str, title: str, description: str, link: str):
sqldb = get_db_session()

feed = FeedGenerator()
feed.title(title)
feed.description(description)
Expand All @@ -56,13 +54,14 @@ def generate_feed(column_name: str, title: str, description: str, link: str):

column = getattr(models.Apps, column_name)

appids = (
sqldb.query(models.Apps)
.filter(column.isnot(None))
.order_by(column.desc())
.limit(10)
.all()
)
with get_db("replica") as sqldb:
appids = (
sqldb.query(models.Apps)
.filter(column.isnot(None))
.order_by(column.desc())
.limit(10)
.all()
)

appids_for_frontend: List[Tuple[str, datetime]] = [
(app.app_id, getattr(app, column_name))
Expand Down

0 comments on commit 202a296

Please sign in to comment.