Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mount paths to secondary drives #177

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

termdisc
Copy link

/run/media/... and /mnt/... are common mount paths for secondary drives where people may install their games. For example, a Steam Deck mounts an SD card at /run/media/deck/<UDID>. Desktop installations may use /mnt for permanently mounted drives as well.

Adding these permissions out the gate would mitigate the initial prompt about not having sufficient permissions to access folders.

@termdisc
Copy link
Author

This looks like a broader version of #136

@flathubbot
Copy link
Contributor

Started test build 175090

@flathubbot
Copy link
Contributor

Build 175090 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/158227/com.github.Matoking.protontricks.flatpakref

@Matoking
Copy link
Collaborator

As far as I know, Flathub applications should not be given broad permissions by default unless really necessary (there are requirements detailed here). I don't believe adding these broad permissions are justified given that there is already a prompt, even if it's a bit janky. This would ideally be solved with a proper API on the Flatpak side or an XDG Portal, but neither is available at the moment.

For what it's worth, the Steam Flatpak only has access to its own app directory by default with instructions in the wiki for external disks should the user want to add any.

@termdisc
Copy link
Author

The linked requirements further links to "Flatpak permissions guide," which also includes a section for external drives. This section includes /mnt, /run/media and one that I neglected to include: /media.

I believe that these are within the scope of these guidelines, especially when you take into account the increase of handheld PCs running SteamOS or SteamOS-like distros.

@flathubbot
Copy link
Contributor

Started test build 175610

@flathubbot
Copy link
Contributor

Build 175610 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/158753/com.github.Matoking.protontricks.flatpakref

@flathubbot
Copy link
Contributor

Started test build 176801

@flathubbot
Copy link
Contributor

Build 176801 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/159955/com.github.Matoking.protontricks.flatpakref

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants