-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mount paths to secondary drives #177
base: master
Are you sure you want to change the base?
Conversation
This looks like a broader version of #136 |
Started test build 175090 |
Build 175090 successful
|
As far as I know, Flathub applications should not be given broad permissions by default unless really necessary (there are requirements detailed here). I don't believe adding these broad permissions are justified given that there is already a prompt, even if it's a bit janky. This would ideally be solved with a proper API on the Flatpak side or an XDG Portal, but neither is available at the moment. For what it's worth, the Steam Flatpak only has access to its own app directory by default with instructions in the wiki for external disks should the user want to add any. |
The linked requirements further links to "Flatpak permissions guide," which also includes a section for external drives. This section includes I believe that these are within the scope of these guidelines, especially when you take into account the increase of handheld PCs running SteamOS or SteamOS-like distros. |
include /media
Started test build 175610 |
Build 175610 successful
|
Started test build 176801 |
Build 176801 successful
|
/run/media/...
and/mnt/...
are common mount paths for secondary drives where people may install their games. For example, a Steam Deck mounts an SD card at/run/media/deck/<UDID>
. Desktop installations may use/mnt
for permanently mounted drives as well.Adding these permissions out the gate would mitigate the initial prompt about not having sufficient permissions to access folders.