Update #3
Merged
Update #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Switch to fallback-x11 - Better source url for gtkspell
|
Started test build 104701 |
|
Build 104701 failed |
|
Started test build 104718 |
|
Build 104718 successful |
- Add dri permission: `libEGL warning: wayland-egl: could not open /dev/dri/renderD128 (No such file or directory)`
|
Started test build 104738 |
|
Build 104738 successful |
bbhtt
commented
Aug 13, 2022
| "sdk": "org.gnome.Sdk", | ||
| "command": "formiko", | ||
| "rename-icon": "formiko", | ||
| "rename-desktop-file": "formiko.desktop", | ||
| "rename-appdata-file": "formiko.metainfo.xml", | ||
| "finish-args" : [ | ||
| "--share=ipc", | ||
| "--socket=x11", | ||
| "--device=dri", | ||
| "--socket=fallback-x11", | ||
| "--socket=wayland", | ||
| "--share=network", | ||
| "--filesystem=home", |
There was a problem hiding this comment.
Is this really needed or can this be reduced to a subset of $HOME like XDG directories? I have opened an issue about using portals ondratu/formiko#39
There was a problem hiding this comment.
I replied to your issue. At this moment it is necessary for preview widget.
ondratu
reviewed
Aug 14, 2022
hfiguiere
reviewed
Aug 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the individual commits for the actual change and ignore the indentation change. It created a lot of noise.
Ping @ondratu please review, thanks!