Skip to content

Add release creation to bump workflow #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flaticols merged 2 commits into from
Dec 14, 2025
Merged

Add release creation to bump workflow #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe14b0a
Add create-release workflow
flaticols Dec 14, 2025
d40c09d
Add release creation to bump workflow
flaticols Dec 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,17 @@ jobs:
fi

- name: Bump version
id: bump
if: steps.bump-type.outputs.type != ''
run: bump ${{ steps.bump-type.outputs.type }} --brave
run: |
bump ${{ steps.bump-type.outputs.type }} --brave
echo "tag=$(git describe --tags --abbrev=0)" >> $GITHUB_OUTPUT
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Create GitHub Release
if: steps.bump.outputs.tag != ''
Copy link

Copilot AI Dec 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition checks if the tag output is not empty, but if the bump step is skipped (when bump-type is empty), the tag output won't exist at all. This will cause a workflow error. The condition should also verify that the bump step was executed: steps.bump.outcome == 'success' && steps.bump.outputs.tag != ''

Suggested change
if: steps.bump.outputs.tag != ''
if: steps.bump.outcome == 'success' && steps.bump.outputs.tag != ''

Copilot uses AI. Check for mistakes.
uses: softprops/action-gh-release@v2
with:
tag_name: ${{ steps.bump.outputs.tag }}
generate_release_notes: true
Loading