-
Notifications
You must be signed in to change notification settings - Fork 0
Add tool directive #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6d328d6
Add -structs CLI flag for struct filtering
flaticols 236b15c
Add package-qualified struct filtering and Go 1.24+ tool documentation
flaticols ca91dae
Apply De Morgan's law simplifications to boolean logic
flaticols 1c67c86
Clean up inline comments and add comprehensive godoc for functions
flaticols 57c2d2b
Add comprehensive godoc and clean up comments across all modules
flaticols 5e95ccb
Trim unnecessary godoc from small functions in main.go
flaticols a84884e
Clean up
flaticols File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation states "Package path uses Go import path format (lowercase with dots/slashes)" which suggests full import paths are supported. However, the implementation in main.go (lines 59-60) only accepts qualified names with exactly one dot, splitting into two parts (package.Struct). This means full import paths like "github.com/user/pkg.Struct" are not supported.
The documentation should clarify that only simple package names are supported for qualification, not full import paths. For example: "Package name must be a simple package identifier (e.g., 'models', 'api', not full import paths)".