Fixing #54 #56
Merged
Fixing #54 #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgarrison
approved these changes
Jan 9, 2024
|
I think there's one issue where this will break things. Let me diagnose before we merge! |
|
Nvm - I think we're ok! This shape handling really is nasty and I'd love to revisit it at some point, but let's merge for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix for #54 was pretty straightforward once I finally narrowed down where it was coming from. We didn't catch this before because we were foiled by NumPy/JAX broadcasting rules.
cc @lgarrison, @Matematija