Add builder_id to builds #120
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can set a builder_id on a token, and that ID will be stored on every build created with that token.
Collaborator
Author
|
Hmm, thinking about this a bit more... This plan assumes that you can't edit buildbot builds with a direct upload token, which isn't a sound assumption if we allow switching from buildbot to direct upload. This needs more design. Maybe if a build is created with a builder_id, it can only be edited by that builder_id? |
Collaborator
Author
|
Or we could track builder_id on the build ref instead of the whole build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can set a builder_id on a token, and that ID will be stored on every build created with that token. We'll use this in flat-manager-hooks to insert an appstream tag for apps built by buildbot.