node: Add yarn2 support #252
Conversation
catsout
force-pushed
the
yarn2
branch
3 times, most recently
from
159ca9f to
ff204fd
Compare
catsout
force-pushed
the
yarn2
branch
2 times, most recently
from
d22a790 to
8aaa053
Compare
|
Isn't lockfile v2 format just normal YAML? |
|
I think you've managed to use this PR in https://sourcegraph.com/github.com/flathub/net.cozic.joplin_desktop@5420d1b2d6c0debe599222af99d048f10de2ac1f/-/blob/net.cozic.joplin_desktop.yml?L62. But just wondering how you get |
|
@proletarius101 |
|
@catsout I found there might be some errors: https://buildbot.flathub.org/#/builders/10/builds/12201 |
|
@proletarius101 |
|
@catsout Could you please push your fix so that I can check, or will you fix it yourself? |
|
@proletarius101 |
True. But do you know why? I thought I confirm that this PR works for standard notes. |
|
Hi @gasinvein @catsout any updates? :) |
|
f0d317a causes the following error: https://buildbot.flathub.org/#/builders/10/builds/13033 afc6911 doesn't |
|
Seems I forgot |
catsout
force-pushed
the
yarn2
branch
3 times, most recently
from
799eb2a to
0894c91
Compare
|
I'm trying to run this on https://github.com/mifi/lossless-cut/blob/37e49d5682a4dada498f3fe7ec3d2d2cf530a7df/yarn.lock but it fails: |
|
@muelli |
|
I'm still experiencing the error. I'm on c278045 now. And I'm calling like this: |
|
Yes, it works. |
|
@catsout , I've used the current latest commit in this PR (eb43ec2) to successfully generate However, the Flatpak build process now fails at The LosslessCut project currently uses Yarn 4.4.0. Do you have any suggestion on which commands to use in |
|
Sorry for the late reply. |
- name: app_example
buildsystem: simple
build-options:
append-path: /usr/lib/sdk/node20/bin
env:
XDG_CACHE_HOME: /run/build/app_example/flatpak-node/cache
npm_config_nodedir: /usr/lib/sdk/node20
YARN_ENABLE_INLINE_BUILDS: '1'
YARN_ENABLE_TELEMETRY: '0'
YARN_ENABLE_NETWORK: '0'
YARN_ENABLE_GLOBAL_CACHE: '0'
YARN_GLOBAL_FOLDER: /run/build/app_example/flatpak-node/yarn-mirror/global
TMPDIR: /run/build/app_example/flatpak-tmp
build-commands:
- yarn config
- yarn plugin import $FLATPAK_BUILDER_BUILDDIR/flatpak-node/flatpak-yarn.js
- yarn convertToZip $(which yarn)
- yarn install |
Since anki now uses yarn 4, some workarounds are required. flatpak-builder-tools upstream does not support yarn >=2, but there is an open PR to add support [1]. That gets most of the way there, but there is still a minor issue that I assume was introduced between yarn 2 and 4 not included in that PR, so I forked it. Anki itself also needs minor changes (yarn-4-fixes.patch) since yarn 4 removed the --offline and --ignore-scripts options, but anki's offline build still uses them. They are now instead set by the flatpak-builder-tools script. Anki uses the YARN_BINARY environment variable, but yarn will interpret any environment variables starting with YARN_ as yarn configuration, so that will need to be renamed. [1] flatpak/flatpak-builder-tools#252
Since anki now uses yarn 4, some workarounds are required. The flatpak environment does not include yarn 4, so it is added to the sources. flatpak-builder-tools upstream does not support yarn >=2, but there is an open PR to add support [1]. That gets most of the way there, but there is still a minor issue that I assume was introduced between yarn 2 and 4 not included in that PR, so I forked from that submitted a PR to the developer of that PR [2]. Anki itself also needs minor changes (yarn-4-fixes.patch) since yarn 4 removed the --offline and --ignore-scripts options, but anki's offline build still uses them. They are now instead set by the flatpak-builder-tools script. Anki uses the YARN_BINARY environment variable, but yarn will interpret any environment variables starting with YARN_ as yarn configuration, so that will need to be renamed. [1] flatpak/flatpak-builder-tools#252 [2] catsout/flatpak-builder-tools#1
Since anki now uses yarn 4, some workarounds are required. The flatpak environment does not include yarn 4, so it is added to the sources. flatpak-builder-tools upstream does not support yarn >=2, but there is an open PR to add support [1]. That gets most of the way there, but there is still a minor issue that I assume was introduced between yarn 2 and 4 not included in that PR, so I forked from that submitted a PR to the developer of that PR [2]. Anki itself also needs minor changes (yarn-4-fixes.patch) since yarn 4 removed the --offline and --ignore-scripts options, but anki's offline build still uses them. They are now instead set by the flatpak-builder-tools script. Anki uses the YARN_BINARY environment variable, but yarn will interpret any environment variables starting with YARN_ as yarn configuration, so that will need to be renamed. [1] flatpak/flatpak-builder-tools#252 [2] catsout/flatpak-builder-tools#1
Since anki now uses yarn 4, some workarounds are required. The flatpak environment does not include yarn 4, so it is added to the sources. flatpak-builder-tools upstream does not support yarn >=2, but there is an open PR to add support [1]. That gets most of the way there, but there is still a minor issue that I assume was introduced between yarn 2 and 4 not included in that PR, so I forked from that submitted a PR to the developer of that PR [2]. Anki itself also needs minor changes (yarn-4-fixes.patch) since yarn 4 removed the --offline and --ignore-scripts options, but anki's offline build still uses them. They are now instead set by the flatpak-builder-tools script. Anki uses the YARN_BINARY environment variable, but yarn will interpret any environment variables starting with YARN_ as yarn configuration, so that will need to be renamed. [1] flatpak/flatpak-builder-tools#252 [2] catsout/flatpak-builder-tools#1
Since anki now uses yarn 4, some workarounds are required. The flatpak environment does not include yarn 4, so it is added to the sources. flatpak-builder-tools upstream does not support yarn >=2, but there is an open PR to add support [1]. That gets most of the way there, but there is still a minor issue that I assume was introduced between yarn 2 and 4 not included in that PR, so I forked from that submitted a PR to the developer of that PR [2]. Anki itself also needs minor changes (yarn-4-fixes.patch) since yarn 4 removed the --offline and --ignore-scripts options, but anki's offline build still uses them. They are now instead set by the flatpak-builder-tools script. Anki uses the YARN_BINARY environment variable, but yarn will interpret any environment variables starting with YARN_ as yarn configuration, so that will need to be renamed. [1] flatpak/flatpak-builder-tools#252 [2] catsout/flatpak-builder-tools#1
Since anki now uses yarn 4, some workarounds are required. The flatpak environment does not include yarn 4, so it is added to the sources. flatpak-builder-tools upstream does not support yarn >=2, but there is an open PR to add support [1]. That gets most of the way there, but there is still a minor issue that I assume was introduced between yarn 2 and 4 not included in that PR, so I forked from that submitted a PR to the developer of that PR [2]. Anki itself also needs minor changes (yarn-4-fixes.patch) since yarn 4 removed the --offline and --ignore-scripts options, but anki's offline build still uses them. They are now instead set by the flatpak-builder-tools script. Anki uses the YARN_BINARY environment variable, but yarn will interpret any environment variables starting with YARN_ as yarn configuration, so that will need to be renamed. [1] flatpak/flatpak-builder-tools#252 [2] catsout/flatpak-builder-tools#1
|
@catsout, thanks for your help! It appears that this PR doesn't yet support projects using Yarn4 as discovered by @holubv in flathub/no.mifi.losslesscut#73 (comment), @RangHo in flathub/social.whalebird.WhalebirdDesktop#23 (comment) and @Oppzippy in flathub/net.ankiweb.Anki#198 (comment). In a way, the situation with building Flatpak apps written in JavaScript from source is pretty unfavorable at the moment. Probably many Flatpak maintainers will find it easier (and currently the only viable option) to just repackage the prebuilt upstream provided binaries... |
bbhtt
force-pushed
the
master
branch
2 times, most recently
from
8c5a0ec to
ea9bfa2
Compare
|
seems like https://github.com/flathub/net.ankiweb.Anki/blob/7ffe4cc7eff554bb41b76d41243effa5e7c30a1f/net.ankiweb.Anki.yaml#L145C7-L146C134 is also pretty helpful ( |
|
yarn2 was such a long time ago. Please help to resolve conflict here and merge. |
11 participants
todo:
need to manually add
$FLATPAK_BUILDER_BUILDDIR/flatpak-node/yarn2-setup.shtobuild-commands