Skip to content

Conversation

@proletarius101
Copy link
Contributor

e.g. In https://raw.githubusercontent.com/lensapp/lens/master/package-lock.json

    "node_modules/npm/node_modules/@colors/colors": {
      "version": "1.5.0",
      "inBundle": true,
      "license": "MIT",
      "optional": true,
      "engines": {
        "node": ">=0.1.90"
      }
    },

f' (package {install_path} in {lockfile})'
)
elif info.get('optional'):
# Optional dependencies can be skipped
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this at least be printing out a warning? Not sure if we do that anywhere else in the source yet, but it could be useful if the user was actually expecting the optional dep to still make its way inside.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@proletarius101 can you add a warning here saying something like "this {package} was skipped due to being optional"

@bbhtt bbhtt requested a review from a team as a code owner June 4, 2025 05:45
@bbhtt bbhtt force-pushed the master branch 2 times, most recently from 8c5a0ec to ea9bfa2 Compare June 4, 2025 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants