add keep-build-dirs flag #229
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Once you have modified the `index.js` of either `flatpak-builder` or `flat-manager` action. Make sure to compile the file to the `dist` directory. You can do so with | ||
| Once you have modified the `index.js` of either `flatpak-builder` or `flat-manager` action, make sure to compile the file to the `dist` directory. | ||
| Note: You should have already installed the npm packages of both `flatpak-builder` and `flat-manager`, with yarn. |
There was a problem hiding this comment.
That is not needed, no? you just need to do a build
There was a problem hiding this comment.
If those packages aren't in the node_modules folders, they don't get included in the bundle and the ncc bundler doesn't even print a warning. At least that's what happened in my case 🤷🏻, feel free to remove it if you can't reproduce
|
can you please rebase? |
|
rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable users run
meson distafter a successfull build.Or in general, to extract some files from the build dir