Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform distro data into introductions and steps #656

Merged
merged 4 commits into from
Dec 24, 2023

Conversation

razzeee
Copy link
Contributor

@razzeee razzeee commented Dec 17, 2023

This seems to work fine, but I haven't made an in depth comparison.

One thing I'm considering, is splitting up steps into name (of the step) and text for that step.

Closes #651

@razzeee razzeee force-pushed the rework-setups branch 3 times, most recently from c2bf96c to e08a8ac Compare December 18, 2023 15:26
@razzeee razzeee marked this pull request as ready for review December 22, 2023 16:30
@razzeee
Copy link
Contributor Author

razzeee commented Dec 22, 2023

This should be good to go. I've even compared the pages before with the after and IMO this only makes them better.

A thing we likely want to do in the future is, make sure, that almost every instruction has steps, currently there are some cases, where that's not given.

data/distro.yml Outdated Show resolved Hide resolved
data/distro.yml Outdated Show resolved Hide resolved
data/distro.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@AsciiWolf AsciiWolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now! :-)

@AsciiWolf AsciiWolf merged commit d526d62 into flatpak:source Dec 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorganize distro data
2 participants