Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve compile warnings #458

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Improve compile warnings #458

wants to merge 10 commits into from

Commits on Oct 24, 2023

  1. Get rid of compiler warnings 

    If we can, we should rejig the code to avoid declaring unused arguments
and variables; if we can't, we can use G_GNUC_UNUSED to eliminate the
warning.
    @ebassi
    ebassi committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    47fc5de View commit details
    Browse the repository at this point in the history

  2. Fix wrong prototype

    @ebassi
    ebassi committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    ebcbf41 View commit details
    Browse the repository at this point in the history

  3. Fix wrong definition 

    Missing `void`. This isn't C++.
    @ebassi
    ebassi committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    fdc92db View commit details
    Browse the repository at this point in the history

  4. Add missing prototypes

    @ebassi
    ebassi committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    1cc2bb1 View commit details
    Browse the repository at this point in the history

  5. Use the appropriate format string 

    The title of the access dialog should not be used as the format string,
otherwise we open ourselves to specially crafted payloads making a mess.
    @ebassi
    ebassi committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    44e5b8c View commit details
    Browse the repository at this point in the history

  6. Respect constness

    @ebassi
    ebassi committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    60d4dc2 View commit details
    Browse the repository at this point in the history

  7. Add default condition 

    Ensure we don't accidentally forget a state.
    @ebassi
    ebassi committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    886c100 View commit details
    Browse the repository at this point in the history

  8. Mark internal functions as static

    @ebassi
    ebassi committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    c6d36b5 View commit details
    Browse the repository at this point in the history

  9. Avoid shadowing variables with arguments 

    Make it clear what we're operating on.
    @ebassi
    ebassi committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    1b35948 View commit details
    Browse the repository at this point in the history

  10. build: Add more warnings 

    Outside of Meson's default warnings, we really need to step up our
coverage.
    @ebassi
    ebassi committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    e36d27d View commit details
    Browse the repository at this point in the history