Skip to content

Conversation

punkbit
Copy link
Contributor

@punkbit punkbit commented Feb 28, 2025

Why?

Currently, there's a case where a user who logs outinvalidates the session) and goes to the Website finds that the login button doesn't trigger the modal (Chrome).

⚠️ Related to https://github.com/FleekHQ/fleek/pull/3723
⚠️ Closed by #24

How?

  • Extend session checkups to include validating localStorage state against cookie tokens
  • Place cookie setter closer to store state handling

Tickets?

Contribution checklist?

  • The commit messages are detailed
  • The build command runs locally
  • Assets or static content are linked and stored in the project
  • Document filename is named after the slug
  • You've reviewed spelling using a grammar checker
  • For documentation, guides or references, you've tested the commands and steps
  • You've done enough research before writing

Security checklist?

  • Sensitive data has been identified and is being protected properly
  • Injection has been prevented (parameterized queries, no eval or system calls)
  • The Components are escaping output (to prevent XSS)

References?

Optionally, provide references such as links

Preview?

login-btn-user-session-validation-checkup-on-refresh--enc.mp4

Copy link

changeset-bot bot commented Feb 28, 2025

🦋 Changeset detected

Latest commit: 1edaf72

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@fleek-platform/login-button Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@punkbit punkbit changed the title Chore/extend session dismissal checks chore: 🤖 Extend session dismissal checkups Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants