update hook, document required config variables in custom config.

fleetdm · Dec 16, 2024 · 0e67737 · 0e67737
1 parent a715700
commit 0e67737
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 3 deletions.
diff --git a/ee/bulk-operations-dashboard/api/hooks/entra-sso/index.js b/ee/bulk-operations-dashboard/api/hooks/entra-sso/index.js
@@ -1,8 +1,8 @@
 /**
  * Module dependencies
  */
-const { ConfidentialClientApplication } = require('@azure/msal-node');
-const jwt = require('jsonwebtoken');
+let { ConfidentialClientApplication } = require('@azure/msal-node');
+let jwt = require('jsonwebtoken');
 
 /**
  * Entra SSO Hook
@@ -79,7 +79,7 @@ module.exports = function (sails) {
     routes: {
       before: {
         '/login': async (req, res) => {
-          // Get the sso login url
+          // Get the sso login url and redirect the user
           // [?]: https://learn.microsoft.com/en-us/javascript/api/%40azure/msal-node/confidentialclientapplication?view=msal-js-latest#@azure-msal-node-confidentialclientapplication-getauthcodeurl
           let entraAuthorizationUrl = await entraSSOClient.getAuthCodeUrl({
             redirectUri: `${sails.config.custom.baseUrl}/authorization-code/callback`,

diff --git a/ee/bulk-operations-dashboard/config/custom.js b/ee/bulk-operations-dashboard/config/custom.js
@@ -107,4 +107,19 @@ module.exports.custom = {
   // [?] Here's how you get one: https://fleetdm.com/docs/using-fleet/fleetctl-cli#get-the-api-token-of-an-api-only-user
   // fleetApiToken: 'asdfasdfasdfasdf',
 
+
+  /**************************************************************************
+  *                                                                         *
+  * Entra SSO configuration                                                  *
+  *                                                                         *
+  **************************************************************************/
+  // entraTenantId: '...', // « The tenant ID of this application in the Microsoft Entra dashboard.
+  // entraClientId: '...', // « The Application (client) ID of this application in the Microsoft Entra dashboard.
+  // entraClientSecret: '...', //« The client secret for the application that has been created for this dashboard.
+  //--------------------------------------------------------------------------
+  // /\  Configure these to replace the built-in authentication with Microsoft Entra SSO.
+  // ||
+  //--------------------------------------------------------------------------
+
+
 };