Skip to content

Commit

Permalink
comments and log update
Browse files Browse the repository at this point in the history
  • Loading branch information
mostlikelee committed Dec 5, 2024
1 parent fcfeabd commit c39aea3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
7 changes: 1 addition & 6 deletions .github/workflows/fleet-and-orbit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -213,12 +213,7 @@ jobs:
# Here we generate the Fleet Desktop and osqueryd targets for
# macOS which can only be generated from a macOS host.
build-macos-targets:
# Set macOS version to '12' (current equivalent to macos-latest) for
# building the binary. This ensures compatibility with macOS version 13 and
# later, avoiding runtime errors on systems using macOS 13 or newer.
#
# Note: Update this version to '13' once GitHub marks macOS 13 as stable
# or if we revise our minimum supported macOS version.
# Set macOS version to '13' for building the binary as Fleet's minimum supported macOS version.
runs-on: macos-13
steps:
- name: Harden Runner
Expand Down
2 changes: 1 addition & 1 deletion orbit/pkg/luks/luks_linux.go
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ func (lr *LuksRunner) getEscrowKey(ctx context.Context, devicePath string) ([]by
}
defer func() {
if err := cancelProgress(); err != nil {
log.Error().Err(err).Msg("failed to cancel progress dialog")
log.Debug().Err(err).Msg("failed to cancel progress dialog")
}
}()

Expand Down

0 comments on commit c39aea3

Please sign in to comment.