return -1 on non ExitError

orbit/pkg/execuser/execuser.go

@@ -43,6 +43,7 @@ func Run(path string, opts ...Option) (lastLogs string, err error) {
 // It assumes the caller is running with high privileges (root on UNIX).
 //
 // It blocks until the child process exits.
+// Non ExitError errors return with a -1 exitCode.
 func RunWithOutput(path string, opts ...Option) (output []byte, exitCode int, err error) {
 	var o eopts
 	for _, fn := range opts {

orbit/pkg/execuser/execuser_linux.go

@@ -48,7 +48,7 @@ func run(path string, opts eopts) (lastLogs string, err error) {
 func runWithOutput(path string, opts eopts) (output []byte, exitCode int, err error) {
 	args, err := getUserAndDisplayArgs(path, opts)
 	if err != nil {
-		return nil, 0, fmt.Errorf("get args: %w", err)
+		return nil, -1, fmt.Errorf("get args: %w", err)
 	}
 
 	args = append(args, path)
@@ -67,7 +67,7 @@ func runWithOutput(path string, opts eopts) (output []byte, exitCode int, err er
 		if exitErr, ok := err.(*exec.ExitError); ok {
 			exitCode = exitErr.ExitCode()
 		}
-		return output, exitCode, fmt.Errorf("%q error: %w", path, err)
+		return output, -1, fmt.Errorf("%q error: %w", path, err)
 	}
 
 	return output, exitCode, nil

orbit/pkg/zenity/zenity.go

@@ -17,7 +17,7 @@ type Zenity struct {
 	cmdWithWait func(ctx context.Context, args ...string) error
 }
 
-// NewZenity creates a new Zenity dialog instance for zenity v4 on Linux.
+// New creates a new Zenity dialog instance for zenity v4 on Linux.
 // Zenity implements the Dialog interface.
 func New() *Zenity {
 	return &Zenity{