-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fleet-maintained apps for macOS #18865
Comments
User stories are derived from the workflows and problems we want to solve. These are documented here in the public Google doc: https://docs.google.com/document/d/13_xJzKldKiSbRknsDFADIf3sESNHapj-7D24Hyu4qro/edit |
This story is related to the "Automate Zoom updates" story (#18961). The user story "Automate Zoom updates" story will be addressed by this story. |
Hey @dherder, we're missing customer/prospect labels for this one. Could you please add labels when you get a chance? |
@marko-lisica this looks to be a duplicate of #17129 |
Thanks @dherder! I think we should keep both, since this one will be focused on software install in case of policy failure. @noahtalerman What's your take on this? |
Agreed. @dherder this story enables this workflow: policy failure => trigger software install (software you've previously uploaded to Fleet). No Tines needed. I think #17129 is similar but for script: policy failure => trigger script. No Tines needed. What do you think? Any feedback? |
sounds good to me, @noahtalerman. |
@dherder This one didn't make to estimation. We plan to prioritize this in the next design sprint. |
Relying on policies to update software creates a lot of overhead in this process. We should be smart enough to determine the version on disk, and if it's < version Fleet has, then install it. This would enable merely uploading new software versions without updating a related policy. Related: fleetdm/confidential#6916 |
From @pacamaster: Include “edit” either package or pre/post-install scripts - currently need to delete and re-add |
#18865 # Checklist for submitter If some of the following don't apply, delete the relevant line. <!-- Note that API documentation changes are now addressed by the product design team. --> - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [x] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) - [x] Added/updated tests - [x] If database migrations are included, checked table schema to confirm autoupdate - For database migrations: - [x] Checked schema for all modified table for columns that will auto-update timestamps during migration. - [x] Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects. - [x] Ensured the correct collation is explicitly set for character columns (`COLLATE utf8mb4_unicode_ci`). - [x] Manual QA for all new/changed functionality
Related to: #18865 Co-authored-by: Rachael Shaw <r@rachael.wtf>
QA testing notes can be found here |
@PezHub @georgekarrv Would you please make sure to update the manual testing steps for every user story? The manual steps and include a link to the sheet that was used to track software. This way, we have a record of what steps we took to validate each software item. Thanks! |
Updated manual testing steps |
Waiting until we bump the server timeout limit to 15 mins to close this story. More context in a separate issue here. |
We bumped the timeout to 15 mins for managed cloud customers ✅ PR to update best practice Terraform is here: #23939 |
PR is merged. Closing this story. |
Apps at fingertips, |
Goal
Context
This is user story applies to this Fleet Q2 OKR:
Changes
Product
dmg
andzip
): Check to see if we mention no support of.dmg
or.zip
in docs. If so, update docs..dmg
and.zip
for Fleet-maintained apps only in this iteration. Bundle identifier for each app should be hardcoded and used during software title creationEngineering
Database schema migrations: Yes
Load testing: Yes
Documentation changes: Yes
QA
Risk assessment
Manual testing steps
Test Fleet UI changes -
*Default is 24hrs but you can force by running
fleetctl trigger --name maintained_apps
End to End testing -
Testing notes
@noahtalerman: We learned that some Microsoft apps (ex. Excel) can point to an XML configuration file at install time to enable/disable certain settings. More info in the "Homebrew format" section in the Google doc here.
We decided to not point to XML in the default install script for these apps because we think the apps can still be installed and used by the end user w/o it. And, we can add Fleet feature for this later.
To be sure, as part of this story, we want to test the following:
As a result
Confirmation
The text was updated successfully, but these errors were encountered: