-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7766 backend final main merge #14427
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… update API only password example (#14171)
Changes: - removed a closing tag that had no opening tag on `basic-article.ejs`. - fixed lint errors in the `basic-article.less` - Fixed the title of a ritual in `ceo.rituals.yml`
fleetdm/confidential#3785 Changes: - Added video testimonials to the homepage. This change has been tested on: - [x] Safari v13 (iOS and macOS) - [x] Android 7 - [x] Firefox v103 - [x] Chrome v80 - [x] Opera v64 - [x] Edge v80 --------- Co-authored-by: Mike Thomas <78363703+mike-j-thomas@users.noreply.github.com>
Minor docs update
…e styles (#14206) Changes: - Added a video testimonial to the vulnerability-management page.
added clarification on running Helm commands in v2 vs v3 --------- Co-authored-by: Rachael Shaw <r@rachael.wtf>
Co-authored-by: Sharon Katz <121527325+sharon-fdm@users.noreply.github.com>
…te MDM macOS setup docs page. (#14124) Closes: #12836 Changes: - Updated the `build-static-content` script to not add HTML comments to Markdown codeblocks, and to not replace HTML comments in generated HTML pages - Updated the custom codeblock renderer in the `to-html` helper to add syntax highlighting classes to Markdown codeblocks. - Updated the indentation of content in lists on the MDM macOS setup docs page. --------- Co-authored-by: Rachael Shaw <r@rachael.wtf> Co-authored-by: Mike McNeil <mikermcneil@users.noreply.github.com>
# Checklist for submitter If some of the following don't apply, delete the relevant line. - [ ] Changes file added for user-visible changes in `changes/` or `orbit/changes/`. See [Changes files](https://fleetdm.com/docs/contributing/committing-changes#changes-files) for more information. - [ ] Documented any API changes (docs/Using-Fleet/REST-API.md or docs/Contributing/API-for-contributors.md) - [ ] Documented any permissions changes (docs/Using Fleet/manage-access.md) - [ ] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) - [ ] Added support on fleet's osquery simulator `cmd/osquery-perf` for new osquery data ingestion features. - [ ] Added/updated tests - [ ] Manual QA for all new/changed functionality - For Orbit and Fleet Desktop changes: - [ ] Manual QA must be performed in the three main OSs, macOS, Windows and Linux. - [ ] Auto-update manual QA, from released version of component to new version (see [tools/tuf/test](../tools/tuf/test/README.md)). --------- Co-authored-by: Sampfluger88 <108141731+Sampfluger88@users.noreply.github.com>
Added additional information about what differentiates the Contributor API routes from the public API routes. # Checklist for submitter Docs-only change
- Removed AE position - Fix "steps after the offer is accepted"
Co-authored-by: Mike McNeil <mikermcneil@users.noreply.github.com>
Shout out to @tdiderich for pointing out this improvement.
Co-authored-by: Mo Zhu <mo@fleetdm.com> Co-authored-by: Mo Zhu <mozhu888@gmail.com> Co-authored-by: Rachael Shaw <r@rachael.wtf>
To help debug/QA #13635
This is needed to automatically populate the secret from outside of the module with an `aws_secretsmanager_secret_version`
Link for Fleet's example ADE profile incorrectly points to a profile called `setup_assistant.json`. The correct profile is `automatic_enrollment.json`. Link is corrected in the PR.
1. **Transition to Feature Fest board** to better manage requests and streamline communication with requestors. 2. **Introduce KPI for customer requests** to monitor customer-driven development. 3. **Feature Fest cleanup** adjusted to include Product Ops and new board process. @zhumo I haven't broken down the new KPIs (for the sake of using less words) but WDYT? --------- Co-authored-by: Mike McNeil <mikermcneil@users.noreply.github.com>
Add additional information about passing/failing CIS benchmark policies # Checklist for submitter Doc-only change
- Add script execution
fleetdm/confidential#3815 Changes: - Updated the text in the homepage hero. - Replaced logos with greyscale versions - Updated the layout and styles to match latest wireframes
Updating Customer section of handbook to remove redundancies.
Co-authored-by: Sampfluger88 <108141731+Sampfluger88@users.noreply.github.com>
Address feedback from Mo: #14167 (comment) Co-authored-by: Mike McNeil <mikermcneil@users.noreply.github.com>
…in yml (#14372) Co-authored-by: Mike McNeil <mikermcneil@users.noreply.github.com>
# Checklist for submitter If some of the following don't apply, delete the relevant line. - [ ] Changes file added for user-visible changes in `changes/` or `orbit/changes/`. See [Changes files](https://fleetdm.com/docs/contributing/committing-changes#changes-files) for more information. - [ ] Documented any API changes (docs/Using-Fleet/REST-API.md or docs/Contributing/API-for-contributors.md) - [ ] Documented any permissions changes (docs/Using Fleet/manage-access.md) - [ ] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) - [ ] Added support on fleet's osquery simulator `cmd/osquery-perf` for new osquery data ingestion features. - [ ] Added/updated tests - [x] Manual QA for all new/changed functionality - For Orbit and Fleet Desktop changes: - [ ] Manual QA must be performed in the three main OSs, macOS, Windows and Linux. - [ ] Auto-update manual QA, from released version of component to new version (see [tools/tuf/test](../tools/tuf/test/README.md)).
FYI this role is ID # 1000 in the fleeties spreadsheet
Co-authored-by: Mike McNeil <mikermcneil@users.noreply.github.com>
- Extended clouds on the homepage - Added repeat-x - Made the cloud shadows more subtle - reduced file size by half # Checklist for submitter - [x] Manual QA for all new/changed functionality
# Checklist for submitter If some of the following don't apply, delete the relevant line. - [ ] Changes file added for user-visible changes in `changes/` or `orbit/changes/`. See [Changes files](https://fleetdm.com/docs/contributing/committing-changes#changes-files) for more information. - [ ] Documented any API changes (docs/Using-Fleet/REST-API.md or docs/Contributing/API-for-contributors.md) - [ ] Documented any permissions changes (docs/Using Fleet/manage-access.md) - [ ] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) - [ ] Added support on fleet's osquery simulator `cmd/osquery-perf` for new osquery data ingestion features. - [ ] Added/updated tests - [ ] Manual QA for all new/changed functionality - For Orbit and Fleet Desktop changes: - [ ] Manual QA must be performed in the three main OSs, macOS, Windows and Linux. - [ ] Auto-update manual QA, from released version of component to new version (see [tools/tuf/test](../tools/tuf/test/README.md)).
# Checklist for submitter If some of the following don't apply, delete the relevant line. - [ ] Changes file added for user-visible changes in `changes/` or `orbit/changes/`. See [Changes files](https://fleetdm.com/docs/contributing/committing-changes#changes-files) for more information. - [ ] Documented any API changes (docs/Using-Fleet/REST-API.md or docs/Contributing/API-for-contributors.md) - [ ] Documented any permissions changes (docs/Using Fleet/manage-access.md) - [ ] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) - [ ] Added support on fleet's osquery simulator `cmd/osquery-perf` for new osquery data ingestion features. - [ ] Added/updated tests - [ ] Manual QA for all new/changed functionality - For Orbit and Fleet Desktop changes: - [ ] Manual QA must be performed in the three main OSs, macOS, Windows and Linux. - [ ] Auto-update manual QA, from released version of component to new version (see [tools/tuf/test](../tools/tuf/test/README.md)).
jacobshandling
requested review from
mikermcneil,
rachaelshaw,
edwardsb and
a team
as code owners
October 10, 2023 19:32
jacobshandling
had a problem deploying
to
Docker Hub
October 10, 2023 19:32 — with
GitHub Actions
Error
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 7766-backend #14427 +/- ##
===============================================
Coverage ? 58.81%
===============================================
Files ? 913
Lines ? 75851
Branches ? 2139
===============================================
Hits ? 44611
Misses ? 27658
Partials ? 3582
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jacobshandling
force-pushed
the
7766-backend-final-main-merge
branch
from
October 10, 2023 19:38
831735b
to
37dbbaf
Compare
jacobshandling
temporarily deployed
to
Docker Hub
October 10, 2023 19:38 — with
GitHub Actions
Inactive
jacobshandling
temporarily deployed
to
Docker Hub
October 10, 2023 19:38 — with
GitHub Actions
Inactive
jacobshandling
temporarily deployed
to
Docker Hub
October 10, 2023 19:53 — with
GitHub Actions
Inactive
jacobshandling
temporarily deployed
to
Docker Hub
October 10, 2023 19:53 — with
GitHub Actions
Inactive
rachaelshaw
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.