#14415 API design: Per-host query report endpoint #14805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fleet-release
previously approved these changes
Oct 30, 2023
rachaelshaw
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
19 tasks
This was referenced Nov 8, 2023
mostlikelee
reviewed
Nov 28, 2023
docs/REST API/rest-api.md
Outdated
| | Name | Type | In | Description | | ||
| | --------- | ------- | ---- | ------------------------------------------ | | ||
| | id | integer | path | **Required**. The ID of the desired query. | | ||
| | host_id | integer | path | If provided, filters to only include results for the specified host. | |
There was a problem hiding this comment.
@rachaelshaw we may need an example for clarity, but to confirm: will it look like this?
GET /api/v1/fleet/queries/31/report/439
There was a problem hiding this comment.
@mostlikelee whoops, I totally meant for host_id to be a query parameter, forgot to change the "In" when I duplicated that line. I just updated the PR; would be weird to have an optional parameter in the path 🤦♀️
So should look like: GET /api/v1/fleet/queries/31/report?host_id=439
fleet-release
previously approved these changes
Nov 28, 2023
rachaelshaw
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
mostlikelee
reviewed
Nov 29, 2023
mostlikelee
reviewed
Nov 29, 2023
fleet-release
approved these changes
Nov 29, 2023
rachaelshaw
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
fleet-release
previously approved these changes
Nov 29, 2023
mostlikelee
reviewed
Nov 29, 2023
Co-authored-by: Tim Lee <timlee@fleetdm.com>
fleet-release
previously approved these changes
Nov 29, 2023
rachaelshaw
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
fleet-release
previously approved these changes
Nov 30, 2023
rachaelshaw
had a problem deploying
to
Docker Hub
GitHub Actions
Error
rachaelshaw
commented
Nov 30, 2023
fleet-release
previously approved these changes
Nov 30, 2023
rachaelshaw
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
rachaelshaw
commented
Dec 8, 2023
fleet-release
previously approved these changes
Dec 8, 2023
rachaelshaw
had a problem deploying
to
Docker Hub
GitHub Actions
Error
rachaelshaw
commented
Dec 8, 2023
fleet-release
approved these changes
Dec 8, 2023
rachaelshaw
had a problem deploying
to
Docker Hub
GitHub Actions
Error
fleet-release
approved these changes
Dec 8, 2023
fleet-release
approved these changes
Dec 8, 2023
rachaelshaw
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
fleet-release
approved these changes
Dec 8, 2023
rachaelshaw
changed the title
fleet-release
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new API endpoint to enable displaying query reports per-host (#14415).