Skip to content

allow fleetctl to configure windows mdm profiles for teams and "no team" #15161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 15, 2023

Conversation

roperzh
Copy link
Contributor

@roperzh roperzh commented Nov 15, 2023

final step of #14361 , this integrates the work of the other PRs.

currently branched off 14361-windows-custom-settings-configs

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/ or orbit/changes/.
    See Changes files for more information.
  • Added/updated tests
  • Manual QA for all new/changed functionality

Base automatically changed from 14361-windows-custom-settings-configs to main November 15, 2023 16:58
@roperzh roperzh force-pushed the 14361-fleetctl-apply-changes branch from 217c879 to 2b5c8d4 Compare November 15, 2023 17:00
@roperzh roperzh force-pushed the 14361-fleetctl-apply-changes branch from 2b5c8d4 to d8577f3 Compare November 15, 2023 17:01
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (319b64f) 58.94% compared to head (0d82295) 58.97%.
Report is 1 commits behind head on main.

Files Patch % Lines
server/service/client.go 70.00% 25 Missing and 5 partials ⚠️
server/service/client_appconfig.go 0.00% 2 Missing ⚠️
server/service/client_teams.go 0.00% 2 Missing ⚠️
server/fleet/teams.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15161      +/-   ##
==========================================
+ Coverage   58.94%   58.97%   +0.02%     
==========================================
  Files         962      962              
  Lines       81764    81832      +68     
  Branches     2274     2274              
==========================================
+ Hits        48195    48257      +62     
+ Misses      29851    29850       -1     
- Partials     3718     3725       +7     
Flag Coverage Δ
backend 59.60% <66.66%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roperzh roperzh marked this pull request as ready for review November 15, 2023 18:32
@roperzh roperzh requested a review from a team as a code owner November 15, 2023 18:32
mna
mna previously approved these changes Nov 15, 2023
Copy link
Member

@mna mna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-authored-by: Martin Angers <martin.n.angers@gmail.com>
@roperzh roperzh merged commit f82cfa3 into main Nov 15, 2023
@roperzh roperzh deleted the 14361-fleetctl-apply-changes branch November 15, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants