Allow reverting a deleted Munki. #15183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #15183 +/- ##
=======================================
Coverage 59.04% 59.04%
=======================================
Files 965 965
Lines 81985 81985
Branches 2277 2277
=======================================
Hits 48405 48405
Misses 29851 29851
Partials 3729 3729
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
getvictor
commented
Nov 17, 2023
| // assume the extension is not there | ||
| return nil | ||
| // munki is not there, and we need to mark it deleted if it was there before | ||
| return ds.SetOrUpdateMunkiInfo(ctx, host.ID, "", []string{}, []string{}) |
There was a problem hiding this comment.
The query select <stuff> from munki_info is part of detail query which is hardcoded in fleetd on the host. If Munki doesn't exist (or was completely wiped) on the host, the query will return no rows. The server will see that as it is processing detail query results from the host.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Munki is deleted and reinstalled on the host, Fleet will show Munki info again.
#12409
Checklist for submitter
changes/ororbit/changes/.See Changes files for more information.